lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Mar 2023 10:40:11 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: David Howells <dhowells@...hat.com> Cc: willy@...radead.org, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, dhowells@...hat.com, viro@...iv.linux.org.uk, hch@...radead.org, axboe@...nel.dk, jlayton@...nel.org, brauner@...nel.org, torvalds@...ux-foundation.org, netdev@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux-crypto@...r.kernel.org Subject: Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() David Howells <dhowells@...hat.com> wrote: > Remove hash_sendpage*() and use hash_sendmsg() as the latter seems to just > use the source pages directly anyway. ... > - if (!(flags & MSG_MORE)) { > - if (ctx->more) > - err = crypto_ahash_finup(&ctx->req); > - else > - err = crypto_ahash_digest(&ctx->req); You've just removed the optimised path from user-space to finup/digest. You need to add them back to sendmsg if you want to eliminate sendpage. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists