linux-kernel - Re: [PATCH V4 2/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167906278443.1989626.14584373898685842817.robh@kernel.org>
Date:   Fri, 17 Mar 2023 09:55:19 -0500
From:   Rob Herring <robh@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     Peng Fan <peng.fan@....com>, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-imx@....com,
        gregkh@...uxfoundation.org, festevam@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        shawnguo@...nel.org, xu.yang_2@....com, robh+dt@...nel.org,
        jun.li@....com, krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH V4 2/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT
 schema format


On Fri, 17 Mar 2023 20:37:04 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Convert the binding to DT schema format. To fix the dtbs_check
> error, some properties were also added, such as nvidia,phy, reset-names
> ulpi; missing compatibles are added.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../devicetree/bindings/usb/ci-hdrc-usb2.txt  | 159 -------
>  .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 412 ++++++++++++++++++
>  2 files changed, 412 insertions(+), 159 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml: properties:pinctrl-names:items: {'enum': ['default', 'host', 'device', 'idle', 'active']} is not of type 'array'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230317123708.337286-3-peng.fan@oss.nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.