linux-kernel - RE: [PATCH] scsi: hpsa: Remove the unused variable transMethod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 15:18:05 +0000
From:   <Don.Brace@...rochip.com>
To:     <jiapeng.chong@...ux.alibaba.com>
CC:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <storagedev@...rochip.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <abaci@...ux.alibaba.com>
Subject: RE: [PATCH] scsi: hpsa: Remove the unused variable transMethod

-----Original Message-----
From: Jiapeng Chong [mailto:jiapeng.chong@...ux.alibaba.com] 
Subject: [PATCH] scsi: hpsa: Remove the unused variable transMethod

Variable transMethod is not effectively used, so delete it.

drivers/scsi/hpsa.c:9478:16: warning: variable 'transMethod' set but not used.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4554
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Don Brace <don.brace@...rochip.com>
Thanks for your patch.

---
 drivers/scsi/hpsa.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index fec7e17747f7..2f2b46a95102 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9475,8 +9475,6 @@ static void hpsa_free_performant_mode(struct ctlr_info *h)  static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)  {
        u32 trans_support;
-       unsigned long transMethod = CFGTBL_Trans_Performant |
-                                       CFGTBL_Trans_use_short_tags;
        int i, rc;

        if (hpsa_simple_mode)
@@ -9488,14 +9486,10 @@ static int hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)

        /* Check for I/O accelerator mode support */
        if (trans_support & CFGTBL_Trans_io_accel1) {
-               transMethod |= CFGTBL_Trans_io_accel1 |
-                               CFGTBL_Trans_enable_directed_msix;
                rc = hpsa_alloc_ioaccel1_cmd_and_bft(h);
                if (rc)
                        return rc;
        } else if (trans_support & CFGTBL_Trans_io_accel2) {
-               transMethod |= CFGTBL_Trans_io_accel2 |
-                               CFGTBL_Trans_enable_directed_msix;
                rc = hpsa_alloc_ioaccel2_cmd_and_bft(h);
                if (rc)
                        return rc;
--
2.20.1.7.g153144c