linux-kernel - [PATCH][next] coda: Remove redundant assignments to variable s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230317160345.421230-1-colin.i.king@gmail.com>
Date:   Fri, 17 Mar 2023 16:03:45 +0000
From:   Colin Ian King <colin.i.king@...il.com>
To:     coda@...cmu.edu, codalist@...a.cs.cmu.edu
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] coda: Remove redundant assignments to variable s

Variable s is being assigned values and it is not being read afterwards.
The assignments are redundant and can be removed.

Cleans up 2 clang-scan warnings:
fs/coda/upcall.c:259:9: warning: Value stored to 's' is never read [deadcode.DeadStores]
        s = ( new_length & ~0x3) +4; /* round up to word boundary */
fs/coda/upcall.c:430:9: warning: Value stored to 's' is never read [deadcode.DeadStores]
        s = (len & ~0x3) + 4;

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 fs/coda/upcall.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index cd6a3721f6f6..1870a91eae86 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -256,7 +256,6 @@ int venus_rename(struct super_block *sb, struct CodaFid *old_fid,
         /* another null terminated string for Venus */
         offset += s;
         inp->coda_rename.destname = offset;
-        s = ( new_length & ~0x3) +4; /* round up to word boundary */
         memcpy((char *)(inp) + offset, new_name, new_length);
         *((char *)inp + offset + new_length) = '\0';
 
@@ -427,7 +426,6 @@ int venus_symlink(struct super_block *sb, struct CodaFid *fid,
 	/* Round up to word boundary and null terminate */
         offset += s;
         inp->coda_symlink.tname = offset;
-        s = (len & ~0x3) + 4;
         memcpy((char *)(inp) + offset, name, len);
         *((char *)inp + offset + len) = '\0';
 
-- 
2.30.2