linux-kernel - Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 16:26:47 +0000
From:   Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
To:     Pankaj Raghav <p.raghav@...sung.com>
CC:     Christoph Hellwig <hch@....de>,
        "# v4 . 16+" <stable@...r.kernel.org>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "javier.gonz@...sung.com" <javier.gonz@...sung.com>,
        "k.jensen@...sung.com" <k.jensen@...sung.com>,
        "jh.i.park@...sung.com" <jh.i.park@...sung.com>
Subject: Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X

Hi Pankaj,

See the output below.

> On Mar 17, 2023, at 4:10 AM, Pankaj Raghav <p.raghav@...sung.com> wrote:
> 
> Hi Saeed,
> On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>> eui64 values are not unique. Here is an example:
>> namespace1
>> nguid   : 36554630529000710025384500000001
>> eui64   : 002538191100104a
>> namespace2
>> nguid   : 36554630529000710025384500000002
>> eui64   : 002538191100104a
>> namespace3
>> nguid   : 36554630529000710025384500000003
>> eui64   : 002538191100104a
>> namespace4
>> nguid   : 36554630529000710025384500000004
>> eui64   : 002538191100104a
>> 
>> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
> 
> I am able to reproduce this error with a PM173X.
> 
> nvme id-ns:
> root@...singno:~# nvme id-ns -n 1 /dev/nvme1 | grep eui64
> eui64   : 00253891010005b3
> root@...singno:~# nvme id-ns -n 2 /dev/nvme1 | grep eui64
> eui64   : 00253891010005b3
> root@...singno:~# nvme id-ns -n 3 /dev/nvme1 | grep eui64
> eui64   : 00253891010005b3
> 
> dmesg:
> [174690.305507] nvme nvme1: identifiers changed for nsid 1
> [174878.481002] nvme nvme1: rescanning namespaces.
> [174878.535981] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174878.599982] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.673001] nvme nvme1: rescanning namespaces.
> [174883.740045] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.784025] nvme nvme1: duplicate IDs in subsystem for nsid 3
> [174883.852034] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.892040] nvme nvme1: duplicate IDs in subsystem for nsid 3
> 
> I will report this to our firmware team. Meanwhile, Could you paste your
> output id-ctrl output here? I am interested in the fw version you are using.

NVME Identify Controller:
vid       : 0x144d
ssvid     : 0x108e
sn        : S64VNE0R602271
mn        : SAMSUNG MZWLR3T8HBLS-00AU3
fr        : MPK94R5Q
rab       : 8
ieee      : 002538
cmic      : 0x3
mdts      : 8
cntlid    : 0x41
ver       : 0x10300
rtd3r     : 0xe4e1c0
rtd3e     : 0x989680
oaes      : 0x300
ctratt    : 0
rrls      : 0
cntrltype : 0
fguid     :
crdt1     : 0
crdt2     : 0
crdt3     : 0
nvmsr     : 1
vwci      : 255
mec       : 3
oacs      : 0x5f
acl       : 127
aerl      : 15
frmw      : 0x17
lpa       : 0xe
elpe      : 255
npss      : 0
avscc     : 0x1
apsta     : 0
wctemp    : 345
cctemp    : 358
mtfa      : 130
hmpre     : 0
hmmin     : 0
tnvmcap   : 3840755982336
unvmcap   : 3989938176
rpmbs     : 0
edstt     : 2
dsto      : 1
fwug      : 255
kas       : 0
hctma     : 0
mntmt     : 0
mxtmt     : 0
sanicap   : 0x3
hmminds   : 0
hmmaxd    : 0
nsetidmax : 0
endgidmax : 0
anatt     : 0
anacap    : 0
anagrpmax : 0
nanagrpid : 0
pels      : 0
domainid  : 0
megcap    : 0
sqes      : 0x66
cqes      : 0x44
maxcmd    : 0
nn        : 32
oncs      : 0x7f
fuses     : 0
fna       : 0x4
vwc       : 0
awun      : 65535
awupf     : 0
icsvscc     : 1
nwpc      : 0
acwu      : 0
ocfs      : 0
sgls      : 0xf0002
mnan      : 0
maxdna    : 0
maxcna    : 0
subnqn    : nqn.1994-11.com.samsung:nvme:PM1733:2.5-inch:S64VNE0R602271
ioccsz    : 0
iorcsz    : 0
icdoff    : 0
fcatt     : 0
msdbd     : 0
ofcs      : 0
ps    0 : mp:25.00W operational enlat:180 exlat:180 rrt:0 rrl:0
          rwt:0 rwl:0 idle_power:7.00W active_power:20.00W

Thanks,
Saeed

> 
> --
> Pankaj