linux-kernel - Re: [RFC PATCH v1] usb/phy add sprd ums512 usbphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Mar 2023 23:15:33 +0800
From:   Cixi Geng <cixi.geng@...ux.dev>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com, arnd@...db.de, tony@...mide.com,
        felipe.balbi@...ux.intel.com, paul@...pouillou.net,
        linus.walleij@...aro.org, cixi.geng1@...soc.com,
        gengcixi@...il.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [RFC PATCH v1] usb/phy add sprd ums512 usbphy

On Mon, 2023-03-13 at 07:31 +0100, Greg KH wrote:
> On Mon, Mar 13, 2023 at 01:14:38AM +0800, Cixi Geng wrote:
> > From: Cixi Geng <cixi.geng1@...soc.com>
> > 
> > This driver is support USB2 phy for Spreadtrum UMS512 SOC's,
> > 
> > Signed-off-by: Cixi Geng <cixi.geng1@...soc.com>
> 
> Why is this "RFC"?  What is left to do on it to be accepted?
this is just the driver code, lack of dt-bindings 
> 
> > ---
> >  drivers/usb/phy/Kconfig           |  10 +
> >  drivers/usb/phy/Makefile          |   1 +
> >  drivers/usb/phy/phy-sprd-ums512.c | 511
> > ++++++++++++++++++++++++++++++
> >  drivers/usb/phy/phy-sprd-ums512.h |  39 +++
> 
> Why do you need a .h file for a single .c file?  Please just put them
> all together into one file.
> 
> thanks,
> 
> greg k-h