linux-kernel - Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <641548b142559_28ae5229425@iweiny-mobl.notmuch>
Date:   Fri, 17 Mar 2023 22:14:25 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>,
        Kloudifold <cloudifold.3125@...il.com>,
        Alison Schofield <alison.schofield@...el.com>
CC:     <teddy.wang@...iconmotion.com>, <sudipm.mukherjee@...il.com>,
        <gregkh@...uxfoundation.org>, <linux-staging@...ts.linux.dev>,
        <outreachy@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

Bagas Sanjaya wrote:
> On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> > Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
> 
> If I only see the subject above, which functions are renamed? I have
> to see the actual diff if the patch description doesn't answer that.
> In this case, I think the proper subject would be `[PATCH v3] staging:
> sm750: Rename sm750_hw_cursor_* functions to snake_case`.

No.  The oneliner is a brief overview.

It is perfectly appropriate to have to look at the diff to see what was
done.  The commit message is to state what the problem was and how it was
fixed.

Ira