linux-kernel - Re: [PATCH] ALSA: ymfpci: remove unused snd_ymfpci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mt49mabx.wl-tiwai@suse.de>
Date:   Sun, 19 Mar 2023 09:09:22 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Tom Rix <trix@...hat.com>
Cc:     perex@...ex.cz, tiwai@...e.com, nathan@...nel.org,
        ndesaulniers@...gle.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] ALSA: ymfpci: remove unused snd_ymfpci_readb function

On Sat, 18 Mar 2023 14:27:08 +0100,
Tom Rix wrote:
> 
> clang with W=1 reports
> sound/pci/ymfpci/ymfpci_main.c:34:18: error:
>   unused function 'snd_ymfpci_readb' [-Werror,-Wunused-function]
> static inline u8 snd_ymfpci_readb(struct snd_ymfpci *chip, u32 offset)
>                  ^
> This static function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

I applied now, but still wondering why it warns at all even if it's a
static inline function...


thanks,

Takashi

> ---
>  sound/pci/ymfpci/ymfpci_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
> index c80114c0ad7b..2858736ed20a 100644
> --- a/sound/pci/ymfpci/ymfpci_main.c
> +++ b/sound/pci/ymfpci/ymfpci_main.c
> @@ -31,11 +31,6 @@
>  
>  static void snd_ymfpci_irq_wait(struct snd_ymfpci *chip);
>  
> -static inline u8 snd_ymfpci_readb(struct snd_ymfpci *chip, u32 offset)
> -{
> -	return readb(chip->reg_area_virt + offset);
> -}
> -
>  static inline void snd_ymfpci_writeb(struct snd_ymfpci *chip, u32 offset, u8 val)
>  {
>  	writeb(val, chip->reg_area_virt + offset);
> -- 
> 2.27.0
>