lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Mar 2023 15:34:07 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Marek BehĂșn <marek.behun@....cz> Cc: Klaus Kudielka <klaus.kudielka@...il.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v4 4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing On Sun, Mar 19, 2023 at 11:06:06AM +0100, Marek BehĂșn wrote: > > + bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip)); > > shouldnt this be > GENMASK(31, mv88e6xxx_num_ports(chip) + chip->info->phy_base_addr) | > GENMASK(chip->info->phy_base_addr, 0) > ? > Or alternatively > ~GENMASK(chip->info->phy_base_addr + mv88e6xxx_num_ports(chip), > chip->info->phy_base_addr) Good point. Would you mind sending a patch? I prefer the second variant BTW.
Powered by blists - more mailing lists