lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 19 Mar 2023 12:46:50 -0400
From:   Steven Rostedt <>
Cc:     Masami Hiramatsu <>,
        Mark Rutland <>,
        Andrew Morton <>,
        Ingo Molnar <>,
        Mike Rapoport <>,
        Vlastimil Babka <>,
        Mukesh Ojha <>
Subject: [for-linus][PATCH 7/8] ring-buffer: remove obsolete comment for free_buffer_page()

From: Vlastimil Babka <>

The comment refers to mm/slob.c which is being removed. It comes from
commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and
according to Steven the borrowed code was a page mapcount and mapping
reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer:
allocate buffer page pointer"). Thus the comment is not accurate anyway,
remove it.


Cc: Masami Hiramatsu <>
Cc: Ingo Molnar <>
Reported-by: Mike Rapoport <>
Suggested-by: Steven Rostedt (Google) <>
Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer")
Signed-off-by: Vlastimil Babka <>
Reviewed-by: Mukesh Ojha <>
Signed-off-by: Steven Rostedt (Google) <>
 kernel/trace/ring_buffer.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 071184324d18..3c7cd135333f 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage)
 	local_set(&bpage->commit, 0);
- * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing
- * this issue out.
- */
 static void free_buffer_page(struct buffer_page *bpage)
 	free_page((unsigned long)bpage->page);

Powered by blists - more mailing lists