linux-kernel - Re: [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230319192405.6202ea2b@bootlin.com>
Date:   Sun, 19 Mar 2023 19:24:05 +0100
From:   Herve Codina <herve.codina@...tlin.com>
To:     Tom Rix <trix@...hat.com>
Cc:     gregkh@...uxfoundation.org, nathan@...nel.org,
        ndesaulniers@...gle.com, linux-renesas-soc@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset
 function

Hi Tom,

On Sun, 19 Mar 2023 11:59:10 -0400
Tom Rix <trix@...hat.com> wrote:

> clang with W=1 reports
> drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function
>   'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function]
> static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
>                    ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/usb/gadget/udc/renesas_usbf.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
> index cb23e62e8a87..84ac9fe4ce7f 100644
> --- a/drivers/usb/gadget/udc/renesas_usbf.c
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset,
>  	usbf_ep_dma_reg_writel(ep, offset, tmp);
>  }
>  
> -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
> -					  u32 clr, u32 set)
> -{
> -	u32 tmp;
> -
> -	tmp = usbf_ep_dma_reg_readl(ep, offset);
> -	tmp &= ~clr;
> -	tmp |= set;
> -	usbf_ep_dma_reg_writel(ep, offset, tmp);
> -}
> -
>  static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1)
>  {
>  	u32 set;

Yes, indeed.

Acked-by: Herve Codina <herve.codina@...tlin.com>

Thanks for the patch.
Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com