lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 19 Mar 2023 20:20:11 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-edac@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR

On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote:
> MODULE_AUTHOR strings don't usually include a newline character.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
>  drivers/edac/amd8111_edac.c | 2 +-
>  drivers/edac/amd8131_edac.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c
> index 7508aa416ddbd..ca718f63fcbcd 100644
> --- a/drivers/edac/amd8111_edac.c
> +++ b/drivers/edac/amd8111_edac.c
> @@ -593,5 +593,5 @@ module_init(amd8111_edac_init);
>  module_exit(amd8111_edac_exit);
> 
>  MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@...driver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@...driver.com>");
>  MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module");
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 1693537109826..28610ba514f4d 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -354,5 +354,5 @@ module_init(amd8131_edac_init);
>  module_exit(amd8131_edac_exit);
> 
>  MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@...driver.com>\n");
> +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@...driver.com>");
>  MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module");
> --

Wanna fix the other two in the EDAC tree:

drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n");
drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n"

?

That macro takes:

/*
 * Author(s), use "Name <email>" or just "Name", for multiple
 * authors use multiple MODULE_AUTHOR() statements/lines.
 */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

and not prose.

You can move the prose to the top comment in the respective file, if it
doesn't contain it yet.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Powered by blists - more mailing lists