linux-kernel - Re: [PATCH] maple_tree: remove unused maple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBdlmDVKdrtM4BXb@casper.infradead.org>
Date:   Sun, 19 Mar 2023 19:42:16 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Liam.Howlett@...cle.com, nathan@...nel.org,
        ndesaulniers@...gle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] maple_tree: remove unused maple_tree functions

On Sun, Mar 19, 2023 at 09:29:03AM -0400, Tom Rix wrote:
> clang with W=1 reports
> lib/maple_tree.c:331:21: error: unused function
>   'mte_set_full' [-Werror,-Wunused-function]
> static inline void *mte_set_full(const struct maple_enode *node)
>                     ^
> lib/maple_tree.c:336:21: error: unused function
>   'mte_clear_full' [-Werror,-Wunused-function]
> static inline void *mte_clear_full(const struct maple_enode *node)
>                     ^
> lib/maple_tree.c:341:20: error: unused function
>   'mte_has_null' [-Werror,-Wunused-function]
> static inline bool mte_has_null(const struct maple_enode *node)
>                    ^
> These static functions are not used, so remove them.

No.  They're just not used yet.  NACK.