linux-kernel - Re: [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Mar 2023 20:49:10 +0100
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        stable@...r.kernel.org
Subject: Re: [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning

On Sun, 2023-03-05 at 20:00 -0800, Randy Dunlap wrote:
> Fix a warning that was reported by the kernel test robot:
> 
> In file included from ../include/math-emu/soft-fp.h:27,
>                  from ../arch/sh/math-emu/math.c:22:
> ../arch/sh/include/asm/sfp-machine.h:17: warning: "__BYTE_ORDER" redefined
>    17 | #define __BYTE_ORDER __BIG_ENDIAN
> In file included from ../arch/sh/math-emu/math.c:21:
> ../arch/sh/math-emu/sfp-util.h:71: note: this is the location of the previous definition
>    71 | #define __BYTE_ORDER __LITTLE_ENDIAN
> 
> Fixes: b929926f01f2 ("sh: define __BIG_ENDIAN for math-emu")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Link: lore.kernel.org/r/202111121827.6v6SXtVv-lkp@...el.com
> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>
> Cc: linux-sh@...r.kernel.org
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: stable@...r.kernel.org
> ---
> v2: add Reviewed-by Geert,
>     rebase to linux-next-20211115
> v3: skipped
> v4: refresh & resend
> 
>  arch/sh/math-emu/sfp-util.h |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff -- a/arch/sh/math-emu/sfp-util.h b/arch/sh/math-emu/sfp-util.h
> --- a/arch/sh/math-emu/sfp-util.h
> +++ b/arch/sh/math-emu/sfp-util.h
> @@ -67,7 +67,3 @@
>    } while (0)
>  
>  #define abort()	return 0
> -
> -#define __BYTE_ORDER __LITTLE_ENDIAN
> -
> -

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913