linux-kernel - [PATCH v2] staging: greybus: use inline function for macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Mar 2023 22:49:35 +0200
From:   Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     outreachy@...ts.linux.dev, johan@...nel.org, elder@...nel.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        eng.mennamahmoud.mm@...il.com, Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH v2] staging: greybus: use inline function for macros

Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a
static inline function.

it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell what type
it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
---
changes in v2:
	remove newlines added in previous patch.
---
 drivers/staging/greybus/gbphy.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
index 1de510499480..03a977056637 100644
--- a/drivers/staging/greybus/gbphy.h
+++ b/drivers/staging/greybus/gbphy.h
@@ -15,8 +15,10 @@ struct gbphy_device {
 	struct list_head list;
 	struct device dev;
 };
-
-#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
+static inline struct gbphy_device *to_gbphy_dev(const struct device *d)
+{
+	return container_of(d, struct gbphy_device, dev);
+}
 
 static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
 {
@@ -44,8 +46,10 @@ struct gbphy_driver {
 
 	struct device_driver driver;
 };
-
-#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
+static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
+{
+	return container_of(d, struct gbphy_driver, driver);
+}
 
 int gb_gbphy_register_driver(struct gbphy_driver *driver,
 			     struct module *owner, const char *mod_name);
-- 
2.34.1