lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Mar 2023 02:50:56 +0000 From: Matthew Wilcox <willy@...radead.org> To: Lorenzo Stoakes <lstoakes@...il.com> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Baoquan He <bhe@...hat.com>, Uladzislau Rezki <urezki@...il.com>, David Hildenbrand <david@...hat.com>, Liu Shixin <liushixin2@...wei.com>, Jiri Olsa <jolsa@...nel.org> Subject: Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > /* for /proc/kcore */ > -extern long vread(char *buf, char *addr, unsigned long count); > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); I don't love the order of the arguments here. Usually we follow memcpy() and have (dst, src, len). This sometimes gets a bit more complex when either src or dst need two arguments, but that's not the case here.
Powered by blists - more mailing lists