linux-kernel - Re: [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07b78baf-e9d2-b4c3-5fe9-01f1b57033ab@amd.com>
Date:   Sun, 19 Mar 2023 19:16:49 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Mark Hasemeyer <markhas@...omium.org>, jsd@...ihalf.com
Cc:     andriy.shevchenko@...ux.intel.com, jarkko.nikula@...ux.intel.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        rrangel@...omium.org, upstream@...ihalf.com, wsa@...nel.org,
        dabros@...gle.com
Subject: Re: [PATCH -next 2/2] i2c: designware: Add support for new SoCs in
 AMDPSP driver


On 3/17/23 14:18, Mark Hasemeyer wrote:
> -	/* Status field in command-response buffer is updated by PSP */
> -	status = READ_ONCE(req->hdr.status);
> +	if (req) {
> +		/* Status field in command-response buffer is updated by PSP */
> +		status = READ_ONCE(req->hdr.status);
> +	} else {
> +		status = psp_smn_read(PSP_MBOX_CMD_OFFSET, &status);
> +		status &= ~PSP_MBOX_FIELDS_READY;
> +	}
>
> The value of the mbox cmd register is getting clobbered by the return value
> from psp_smn_read. This can cause bus arbitration to fail as the driver will
> think it can grab the bus when it's actually in use by the PSP.

Mark - FYI this approach is being superseded by another patch series 
that instead uses MMIO from the CCP driver.

It would be better to comment on that series.

https://lore.kernel.org/linux-i2c/20230310211954.2490-9-mario.limonciello@amd.com/