linux-kernel - Re: [PATCH v3] staging: greybus: use inline function for macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBh+3W4eTL9IMW3n@kroah.com>
Date:   Mon, 20 Mar 2023 16:42:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
Cc:     outreachy@...ts.linux.dev, johan@...nel.org, elder@...nel.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH v3] staging: greybus: use inline function for macros

On Mon, Mar 20, 2023 at 12:32:58PM +0200, Menna Mahmoud wrote:
> Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a
> static inline function.
> 
> it is not great to have macro that use `container_of` macro,
> because from looking at the definition one cannot tell what type
> it applies to.
> 
> One can get the same benefit from an efficiency point of view
> by making an inline function.
> 
> Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
> ---
> change in v2:
> 	remove newlines added in previous patch.
> 
> change in v3:
> 	fix the patch to be against Greg's tree.

I am lost in a twisty maze of patches from you for the greybus code that
all seem alike but are different :(

Can you send a patch series of the latest changes you have made, as I
really don't know what is, and is not, the latest versions at all, so
I'm going to have to drop them all from my review queue right now.

thanks,

greg k-h