linux-kernel - Re: [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b98429b7-2932-6bd5-39bc-f82c747b4333@arinc9.com>
Date:   Mon, 20 Mar 2023 19:43:11 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        linux-clk@...r.kernel.org
Cc:     linux-mips@...r.kernel.org, tsbogend@...ha.franken.de,
        john@...ozen.org, linux-kernel@...r.kernel.org,
        p.zabel@...gutronix.de, mturquette@...libre.com, sboyd@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com, devicetree@...r.kernel.org
Subject: Re: [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device
 tree binding documentation

On 20.03.2023 19:36, Krzysztof Kozlowski wrote:
> On 20/03/2023 17:18, Sergio Paracuellos wrote:
>> Adds device tree binding documentation for clocks and resets in the
>> Mediatek MIPS and Ralink SOCs. This covers RT2880, RT3050, RT3052, RT3350,
>> RT3883, RT5350, MT7620, MT7628 and MT7688 SoCs.
> 
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
> 
> Subject: drop second/last, redundant "device tree binding
> documentation". The "dt-bindings" prefix is already stating that these
> are bindings.
> (BTW, that's the longest redundant component I ever saw)
> 
>>
>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
>> ---
>>   .../bindings/clock/mtmips-clock.yaml          | 68 +++++++++++++++++++
>>   1 file changed, 68 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/mtmips-clock.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/mtmips-clock.yaml b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml
>> new file mode 100644
>> index 000000000000..c92969ce231d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml
> 
> Filename matching compatible, so vendor prefix and device name (or
> family of names).

I influenced Sergio to use MTMIPS here as I want to designate it the 
family name for the MediaTek MIPS and Ralink SoCs. We can't change the 
compatible string as it's established from my pinctrl patch series we 
don't do that.

Arınç