linux-kernel - Re: [PATCH v8] staging: axis-fifo: initialize timeouts in init only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3648719.TKLx3GfHUD@suse>
Date:   Mon, 20 Mar 2023 17:55:20 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     outreachy@...ts.linux.dev,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8] staging: axis-fifo: initialize timeouts in init only

On lunedì 20 marzo 2023 15:36:03 CET Khadija Kamran wrote:
> On Mon, Mar 20, 2023 at 02:38:24PM +0100, Fabio M. De Francesco wrote:
> > On lunedì 20 marzo 2023 07:34:04 CET Khadija Kamran wrote:
> > > On Fri, Mar 17, 2023 at 11:29:25AM +0100, Fabio M. De Francesco wrote:
> > > > Khadija,
> > > > 
> > > > Congratulations for having your first patch in Linux, via Greg's 
staging
> > > > tree.
> > > > 
> > > > It will take some time before it reaches mainline, although it is
> > > > already on its way to get upstream.
> > > 
> > > [snip]
> > >
> > I'm confused by this statement. Can you please rephrase?
> > 
> > > Am I getting it right?
> > 
> > Not sure, it depends on what you meant with the previous phrase.
> 
> As you said above that the commit message makes the reader miss the
> permission details, so should we write more about permissions in the
> description?

No. Greg took your patch as is.
No new versions for patches that Maintainers (i.e., Greg Kroah-Hartman for 
drivers/staging and several other subsystems and drivers) already applied.

We've been discussing this topic after Greg had already taken your patch only 
for the purpose to clarify to you why he suggested a better commit message. 
However, he suggested that better message while stating that he prefers to 
take your patch as is to give you time to work on something new.

I suppose that you received the two automated messages, the first which 
communicates that your patch has been applied to his staging-test tree and the 
second which says that it has moved forward to the next step, which is the 
staging-next tree. I saw those messages in Cc because I put my "Reviewed-by" 
tag to your patch, so I know you had them.

Fabio

P.S.: Today I sent you an off-list message. Please locate it and reply.

> > > Thank you!
> > > 
> > > Regards,
> > > Khadija
> > 
> > You're welcome!
> > 
> > So, thanks for working on this patch as long as it takes to get it done.
> > 
> > I think the lesson to be learned is that in our community there are 
barriers
> > to the entry of substandard products and therefore people have to do their
> > best if they really want to see their work applied.
> 
> Yes, you are right. Due to this reason, the whole process is making me
> learn a lot. I am really glad to be a part of it ^-^
> 
> > These tasks are not for the "faints of heart" :-)
> > 
> > Fabio
> 
> Regards,
> Khadija :)