[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <922eab51-6931-8533-db51-51cd911a36b3@linaro.org>
Date: Mon, 20 Mar 2023 19:04:22 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Lin, Meng-Bo" <linmengbo0689@...tonmail.com>,
linux-kernel@...r.kernel.org
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Nikita Travkin <nikita@...n.ru>,
Stephan Gerhold <stephan@...hold.net>,
linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: aw2013: Document vddio-supply
On 20/03/2023 18:55, Lin, Meng-Bo wrote:
> Some LEDs controllers are used with external pull-up for the interrupt
> line and the I2C lines, so we might need to enable a regulator to bring
> the lines into usable state.
Not a property of this device.
> Otherwise, this might cause spurious
> interrupts and reading from I2C will fail.
>
> Document support for "vddio-supply" that is enabled by the aw2013 driver
> so that the regulator gets enabled when needed.
>
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@...tonmail.com>
> ---
> Documentation/devicetree/bindings/leds/leds-aw2013.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> index 08f3e1cfc1b1..79b69cf1d1fe 100644
> --- a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> @@ -23,6 +23,11 @@ properties:
> vcc-supply:
> description: Regulator providing power to the "VCC" pin.
>
> + vddio-supply:
> + description: |
> + Optional regulator that provides digital I/O voltage,
NAK. I responded to your patch and you just send a v2 without explanation.
The device does not have VDDIO pin, either.
Best regards,
Krzysztof
Powered by blists - more mailing lists