linux-kernel - Re: [PATCH v3 20/21] dt-bindings: pinctrl: mediatek: mt7620: split binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2023 21:34:10 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Rob Herring <robh@...nel.org>,
        William Dean <williamsukatube@...il.com>,
        Sean Wang <sean.wang@...nel.org>,
        Andy Teng <andy.teng@...iatek.com>,
        Daniel Golle <daniel@...rotopia.org>,
        Hui Liu <hui.liu@...iatek.com>,
        Zhiyong Tao <zhiyong.tao@...iatek.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Daniel Santos <daniel.santos@...ox.com>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Sean Wang <sean.wang@...iatek.com>, erkin.bozoglu@...ont.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v3 20/21] dt-bindings: pinctrl: mediatek: mt7620: split
 binding

On 20.03.2023 18:00, AngeloGioacchino Del Regno wrote:
> Il 17/03/23 22:30, arinc9.unal@...il.com ha scritto:
>> From: Arınç ÜNAL <arinc.unal@...nc9.com>
>>
>> The MT7628 and MT7688 SoCs contain different pin muxing information,
>> therefore, should be split. This can be done now that there are 
>> compatible
>> strings to distinguish them from other SoCs.
>>
>> Split the schema out to mediatek,mt76x8-pinctrl.yaml.
>>
>> Remove mediatek,mt76x8-pinctrl from mt7620.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> ---
>>   .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 379 +--------------
>>   .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 450 ++++++++++++++++++
> 
> AFAIK, wildcards aren't allowed, so the new file should instead be called
> "mediatek,mt7628-pinctrl.yaml", the compatible string 
> "ralink,mt76x8-pinctrl"
> should be deprecated (but still present as to not break ABI), and the 
> driver
> updated to accept the compatible string "ralink,mt7628-pinctrl".
> 
> At that point, you could update the devicetrees as well: for MT7628, you'd
> have a node using
> 
> compatible = "ralink,mt7628-pinctrl";
> 
> while for MT7688, you'd have
> 
> compatible = "ralink,mt7688-pinctrl", "ralink,mt7628-pinctrl";
> 
> If you don't want to go through those lengths, you could still do the
> cleanup that you wanted to perform, but with a filename containing no
> wildcards - anyway.

I was able to have it accepted by Rob, and the patches are already 
applied so I'm going to leave it as is for now.

Arınç