linux-kernel - Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBioN46Imb07RQP2@li-27defe4c-32e1-11b2-a85c-e202e9981075.ibm.com>
Date:   Tue, 21 Mar 2023 00:08:47 +0530
From:   Abhirup Deb <abhirupdeb@...ux.vnet.ibm.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro

On Sat, Mar 18, 2023 at 10:51:00AM +0300, Dan Carpenter wrote:
> On Sat, Mar 18, 2023 at 12:30:41PM +0530, Abhirup Deb wrote:
> > -#define TSI148_PCFS_STAT_SELTIM        (3<<9)	/* DELSEL Timing */
> > +#define TSI148_PCFS_STAT_SELTIM        BIT(9)	/* DELSEL Timing */
> 
> This patch is buggy.
> 
> regards,
> dan carpenter

Dan,
Thank you for your help! I will be amending the changes in a v2 of the patch.

Regards,
Abhirup Deb