linux-kernel - Re: [PATCH -next] mtd: ubi: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cce0dab6-01f4-11d4-6885-381171b7199e@huawei.com>
Date:   Mon, 20 Mar 2023 10:28:41 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <miquel.raynal@...tlin.com>
CC:     <vigneshr@...com>, <richard@....at>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] mtd: ubi: Simplify bool conversion

在 2023/2/15 9:21, Yang Li 写道:
> ./drivers/mtd/ubi/build.c:1261:33-38: WARNING: conversion to bool not needed here
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4061
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/mtd/ubi/build.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index 0904eb40c95f..e9c153b7c471 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -1258,7 +1258,7 @@ static int __init ubi_init(void)
>   		mutex_lock(&ubi_devices_mutex);
>   		err = ubi_attach_mtd_dev(mtd, p->ubi_num,
>   					 p->vid_hdr_offs, p->max_beb_per1024,
> -					 p->enable_fm == 0 ? true : false);
> +					 p->enable_fm == 0);
>   		mutex_unlock(&ubi_devices_mutex);
>   		if (err < 0) {
>   			pr_err("UBI error: cannot attach mtd%d\n",
> 

Looks good.

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>