linux-kernel - Re: [PATCH v2 2/5] dt-bindings: trivial-devices: Add acbel,crps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13782cac-c46d-4299-896f-ac0341c26f45@roeck-us.net>
Date:   Mon, 20 Mar 2023 13:41:09 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Lakshmi Yadlapati <lakshmiy@...ibm.com>
Cc:     robh+dt@...nel.org, jdelvare@...e.com,
        krzysztof.kozlowski+dt@...aro.org, joel@....id.au, andrew@...id.au,
        eajames@...ux.ibm.com, linux-kernel@...r.kernel.org,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: trivial-devices: Add acbel,crps

On Mon, Mar 20, 2023 at 10:40:16AM -0500, Lakshmi Yadlapati wrote:
> Add Acbel CRPS Series power supply to trivial devices.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@...ibm.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6f482a254a1d..ae2cf4411b39 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -30,6 +30,8 @@ properties:
>      items:
>        - enum:
>              # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
> +          - acbel,crps
> +            # Acbel CRPS Series power supply

This is way too generic. There is not just one Acbel CRPS power supply,
there is a whole lot of them. It is very unlikely that they can all
be described with a single devicetree "compatible" property.

Guenter

>            - ad,ad7414
>              # ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems
>            - ad,adm9240
> -- 
> 2.37.2
>