linux-kernel - RE: [PATCH] workqueue: Introduce show_freeze_workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03f001d95ad7$7a9146f0$6fb3d4d0$@samsung.com>
Date:   Mon, 20 Mar 2023 11:55:50 +0900
From:   "Jungseung Lee" <js07.lee@...sung.com>
To:     "'Tejun Heo'" <tj@...nel.org>
Cc:     "'Lai Jiangshan'" <jiangshanlai@...il.com>,
        "'Rafael J. Wysocki'" <rafael@...nel.org>,
        "'Pavel Machek'" <pavel@....cz>,
        "'Len Brown'" <len.brown@...el.com>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <bw365.lee@...sung.com>, <yw85.kim@...sung.com>,
        <huijin.park@...sung.com>
Subject: RE: [PATCH] workqueue: Introduce show_freeze_workqueues_busy

Hi, Tejun

>-----Original Message-----
>From: Tejun Heo <htejun@...il.com> On Behalf Of Tejun Heo
>Sent: Saturday, March 18, 2023 7:16 AM
>To: Jungseung Lee <js07.lee@...sung.com>
>Cc: Lai Jiangshan <jiangshanlai@...il.com>; Rafael J. Wysocki
><rafael@...nel.org>; Pavel Machek <pavel@....cz>; Len Brown
><len.brown@...el.com>; linux-kernel@...r.kernel.org; linux-
>pm@...r.kernel.org; bw365.lee@...sung.com; yw85.kim@...sung.com;
>huijin.park@...sung.com
>Subject: Re: [PATCH] workqueue: Introduce show_freeze_workqueues_busy
>
>Hello,
>
>A few nits.
>
>On Wed, Mar 15, 2023 at 09:45:57PM +0900, Jungseung Lee wrote:
>> diff --git a/kernel/power/process.c b/kernel/power/process.c index
>> 6c1c7e5..590550f 100644
>> --- a/kernel/power/process.c
>> +++ b/kernel/power/process.c
>> @@ -93,7 +93,7 @@ static int try_to_freeze_tasks(bool user_only)
>>  		       todo - wq_busy, wq_busy);
>>
>>  		if (wq_busy)
>> -			show_all_workqueues();
>> +			show_freeze_workqueues_busy();
>
>Maybe name this show_freezable_workqueues()?
>
>> @@ -5043,7 +5043,7 @@ static void show_one_worker_pool(struct
>> worker_pool *pool)
>>  /**
>>   * show_all_workqueues - dump workqueue state
>>   *
>> - * Called from a sysrq handler or try_to_freeze_tasks() and prints
>> out
>> + * Called from a sysrq handler and prints out
>>   * all busy workqueues and pools.
>
>Can you reflow the comment to 80-col?
>
>> +/**
>> + * show_freeze_workqueues_busy - dump freezable workqueue state
>> + *
>> + * Called from try_to_freeze_tasks() and prints out
>> + * all freezable workqueues still busy.
>
>Ditto.
>

Thank you for the review and I will send a new patch including what you
mentioned soon

Thanks,

>Thanks.
>
>--
>tejun