linux-kernel - Re: [PATCH] mm: kfence: fix PG_slab and memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230320142954.fd314c5e46c1d18887ccf8cc@linux-foundation.org>
Date:   Mon, 20 Mar 2023 14:29:54 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     glider@...gle.com, elver@...gle.com, dvyukov@...gle.com,
        sjpark@...zon.de, jannh@...gle.com, muchun.song@...ux.dev,
        roman.gushchin@...ux.dev, kasan-dev@...glegroups.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: kfence: fix PG_slab and memcg_data clearing

On Mon, 20 Mar 2023 11:00:59 +0800 Muchun Song <songmuchun@...edance.com> wrote:

> It does not reset PG_slab and memcg_data when KFENCE fails to initialize
> kfence pool at runtime. It is reporting a "Bad page state" message when
> kfence pool is freed to buddy. The checking of whether it is a compound
> head page seems unnecessary sicne we already guarantee this when allocating
> kfence pool, removing the check to simplify the code.
> 
> Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure")
> Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation")
> Signed-off-by: Muchun Song <songmuchun@...edance.com>

I'm not sure how the -stable maintainers are to handle two Fixes: tags.
Can we narrow it down to one please?  I assume 8f0b36497303 triggered
the bad_page() warning?