linux-kernel - Re: [RESEND PATCH v3 0/3] thermal: qcom-spmi-temp-alarm: add support for new TEMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35d71338-3524-a46c-e434-bee47cfba0cb@quicinc.com>
Date:   Mon, 20 Mar 2023 16:51:37 -0700
From:   David Collins <quic_collinsd@...cinc.com>
To:     Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>
CC:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Zhang Rui <rui.zhang@...el.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v3 0/3] thermal: qcom-spmi-temp-alarm: add support
 for new TEMP_ALARM subtypes

On 1/24/23 15:46, David Collins wrote:
> Add support in the qcom-spmi-temp-alarm driver for the new PMIC
> TEMP_ALARM peripheral subtypes: GEN2 rev 2 and LITE.  The GEN2 rev 2
> subtype provides greater flexibility in temperature threshold
> specification by using an independent register value to configure
> each of the three thresholds.  The LITE subtype utilizes a simplified
> set of control registers to configure two thresholds: warning and
> shutdown.
> 
> Also add support to avoid a potential issue on certain versions of
> the TEMP_ALARM GEN2 subtype when automatic stage 2 partial shutdown
> is disabled.
> 
> Changes since v2 [1]:
> * Added missing header <linux/bitfield.h> in the third patch
> 
> Changes since v1 [2]:
> * Updated the thermal API usage in the patches to work with the recent commit
>   ca1b9a9eb3fd ("thermal/drivers/qcom: Switch to new of API")
> 
> [1]: https://lore.kernel.org/lkml/cover.1670375556.git.quic_collinsd@quicinc.com/
> [2]: https://lore.kernel.org/lkml/cover.1663282895.git.quic_collinsd@quicinc.com/
> 
> David Collins (3):
>   thermal: qcom-spmi-temp-alarm: enable stage 2 shutdown when required
>   thermal: qcom-spmi-temp-alarm: add support for GEN2 rev 2 PMIC
>     peripherals
>   thermal: qcom-spmi-temp-alarm: add support for LITE PMIC peripherals
> 
>  drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 407 +++++++++++++++++++-
>  1 file changed, 392 insertions(+), 15 deletions(-)

Hello Amit and Thara,

Could you please take a look at this patch series when you have some
time?  It hasn't received any feedback yet after being sent out on
1/24/2023.

According to the MAINTAINERS files, you are the maintainers for all
files in the drivers/thermal/qcom/ directory:

QUALCOMM TSENS THERMAL DRIVER
M:	Amit Kucheria <amitk@...nel.org>
M:	Thara Gopinath <thara.gopinath@...il.com>
L:	linux-pm@...r.kernel.org
L:	linux-arm-msm@...r.kernel.org
S:	Maintained
F:	Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
F:	drivers/thermal/qcom/

Can you please check if this entry needs to be updated?  The
drivers/thermal/qcom directory now contains the qcom-tsens driver as
well as three other independent QCOM thermal drivers:
qcom-spmi-temp-alarm, qcom-spmi-adc-tm5, and lmh.

Thanks,
David