linux-kernel - Re: [PATCH v2] input: alps: fix compatibility with -funsigned-char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBfkYEe0LfITyiUh@google.com>
Date:   Sun, 19 Mar 2023 21:43:12 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     msizanoen <msizanoen@...labs.xyz>
Cc:     hdegoede@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, pali@...nel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] input: alps: fix compatibility with -funsigned-char

Hi,

On Mon, Mar 20, 2023 at 01:17:31AM +0100, msizanoen wrote:
> The AlpsPS/2 code previously relied on the assumption that `char` is a
> signed type, which was true on x86 platforms (the only place where this
> driver is used) before kernel 6.2. However, on 6.2 and later, this
> assumption is broken due to the introduction of -funsigned-char as a new
> global compiler flag.
> 
> Fix this by explicitly specifying the signedness of `char` when sign
> extending the values received from the device.
> 
> v2:
> 	Add explicit signedness to more places
> 
> Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> Cc: stable@...r.kernel.org
> Signed-off-by: msizanoen <msizanoen@...labs.xyz>

Please use s8 instead of signed char. Also, could you please tell me if
"msizanoen" is your real name? It is required in the DCO. Apologies if
it really is.

Thanks.

-- 
Dmitry