| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4cf91114-65e7-ba7d-28d3-6f2f93affbde@starfivetech.com>
Date: Mon, 20 Mar 2023 14:24:37 +0800
From: Jack Zhu <jack.zhu@...rfivetech.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Robert Foss <rfoss@...nel.org>,
"Todor Tomov" <todor.too@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
"Jernej Skrabec" <jernej.skrabec@...il.com>,
Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
"Eugen Hristev" <eugen.hristev@...labora.com>,
<linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <changhuang.liang@...rfivetech.com>
Subject: Re: [PATCH v2 1/6] media: dt-bindings: Add bindings for JH7110 Camera
Subsystem
On 2023/3/12 19:12, Laurent Pinchart wrote:
> Hi Jack,
>
> Thank you for the patch.
Thank you for your comments.
>
> On Fri, Mar 10, 2023 at 08:05:48PM +0800, Jack Zhu wrote:
>> Add the bindings documentation for Starfive JH7110 Camera Subsystem
>> which is used for handing image sensor data.
>>
>> Signed-off-by: Jack Zhu <jack.zhu@...rfivetech.com>
>> ---
>> .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++
>> 1 file changed, 144 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
>> new file mode 100644
>> index 000000000000..3f348dd53441
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
>> @@ -0,0 +1,144 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Starfive SoC CAMSS ISP
>> +
>> +maintainers:
>> + - Jack Zhu <jack.zhu@...rfivetech.com>
>> + - Changhuang Liang <changhuang.liang@...rfivetech.com>
>> +
>> +description:
>> + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It
>
> s/.It/. It/
OK, will fix
>
>> + consists of a VIN controller(Video In Controller, a top-level control until)
>
> s/(/ (/
OK, will fix
>
>> + and an ISP.
>> +
>> +properties:
>> + compatible:
>> + const: starfive,jh7110-camss
>> +
>> + reg:
>> + maxItems: 2
>> +
>> + reg-names:
>> + items:
>> + - const: syscon
>> + - const: isp
>> +
>> + clocks:
>> + maxItems: 7
>> +
>> + clock-names:
>> + items:
>> + - const: apb_func
>> + - const: wrapper_clk_c
>> + - const: dvp_inv
>> + - const: axiwr
>> + - const: mipi_rx0_pxl
>> + - const: ispcore_2x
>> + - const: isp_axi
>> +
>> + resets:
>> + maxItems: 6
>> +
>> + reset-names:
>> + items:
>> + - const: wrapper_p
>> + - const: wrapper_c
>> + - const: axird
>> + - const: axiwr
>> + - const: isp_top_n
>> + - const: isp_top_axi
>> +
>> + power-domains:
>> + items:
>> + - description: JH7110 ISP Power Domain Switch Controller.
>> +
>> + interrupts:
>> + maxItems: 4
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@1:
>
> Why port@1 if there is no port@0 ?
Will add port@0 node in the next version.
port@0 is reserved for DVP sensor which is not currently supported.
>
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>
> I think you can use
>
> $ref: /schemas/graph.yaml#/properties/port
>
> here as you don't define any additional property for the port node.
OK, will alter it
>
>> + unevaluatedProperties: false
>> + description:
>> + Input port for receiving CSI data.
>> +
>> + properties:
>> + endpoint:
>> + $ref: video-interfaces.yaml#
>> + unevaluatedProperties: false
>> +
>> + required:
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - clocks
>> + - clock-names
>> + - resets
>> + - reset-names
>> + - power-domains
>> + - interrupts
>
> The 'ports' node should be mandatory too.
OK, will fix. Thanks.
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + stfcamss: isp@...40000 {
>
> You can drop the label as it's not used.
OK, will drop.
>
>> + compatible = "starfive,jh7110-camss";
>> + reg = <0x19840000 0x10000>,
>> + <0x19870000 0x30000>;
>> + reg-names = "syscon", "isp";
>> + clocks = <&ispcrg 0>,
>> + <&ispcrg 13>,
>> + <&ispcrg 2>,
>> + <&ispcrg 12>,
>> + <&ispcrg 1>,
>> + <&syscrg 51>,
>> + <&syscrg 52>;
>> + clock-names = "apb_func",
>> + "wrapper_clk_c",
>> + "dvp_inv",
>> + "axiwr",
>> + "mipi_rx0_pxl",
>> + "ispcore_2x",
>> + "isp_axi";
>> + resets = <&ispcrg 0>,
>> + <&ispcrg 1>,
>> + <&ispcrg 10>,
>> + <&ispcrg 11>,
>> + <&syscrg 41>,
>> + <&syscrg 42>;
>> + reset-names = "wrapper_p",
>> + "wrapper_c",
>> + "axird",
>> + "axiwr",
>> + "isp_top_n",
>> + "isp_top_axi";
>> + power-domains = <&pwrc 5>;
>> + interrupts = <92>, <87>, <88>, <90>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@1 {
>> + reg = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + vin_from_csi2rx: endpoint {
>> + remote-endpoint = <&csi2rx_to_vin>;
>> + };
>> + };
>> + };
>> + };
>
Powered by blists - more mailing lists