[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7ca0728c-085b-1b4c-96e7-93c6643d7637@starfivetech.com>
Date: Mon, 20 Mar 2023 14:30:41 +0800
From: Jack Zhu <jack.zhu@...rfivetech.com>
To: Rob Herring <robh@...nel.org>
CC: <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
"Jernej Skrabec" <jernej.skrabec@...il.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Maxime Ripard <mripard@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
<changhuang.liang@...rfivetech.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
Todor Tomov <todor.too@...il.com>,
Eugen Hristev <eugen.hristev@...labora.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Robert Foss <rfoss@...nel.org>,
"Mauro Carvalho Chehab" <mchehab@...nel.org>
Subject: Re: [PATCH v2 2/6] media: dt-bindings: cadence-csi2rx: Convert to DT
schema
On 2023/3/10 21:55, Rob Herring wrote:
>
> On Fri, 10 Mar 2023 20:05:49 +0800, Jack Zhu wrote:
>> Convert DT bindings document for Cadence MIPI-CSI2 RX controller
>> to DT schema format and add new properties.
>>
>> Signed-off-by: Jack Zhu <jack.zhu@...rfivetech.com>
>> ---
>> .../devicetree/bindings/media/cdns,csi2rx.txt | 100 -----------
>> .../bindings/media/cdns,csi2rx.yaml | 163 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 3 files changed, 164 insertions(+), 100 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt
>> create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/media/cdns,csi2rx.example.dts:18.30-58.11: Warning (unit_address_format): /example-0/csi@...60000: unit name should not have leading 0s
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230310120553.60586-3-jack.zhu@starfivetech.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
OK, will fix. Thanks.
Powered by blists - more mailing lists