linux-kernel - Re: [PATCH] Staging: greybus: Fix lines ending with '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 20 Mar 2023 14:33:43 +0500
From:   Khadija Kamran <kamrankhadijadj@...il.com>
To:     outreachy@...ts.linux.dev
Cc:     Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Sumitra Sharma <sumitraartsy@...il.com>
Subject: Re: [PATCH] Staging: greybus: Fix lines ending with '('

On Sun, Mar 19, 2023 at 09:45:20AM -0700, Sumitra Sharma wrote:
> The coding style used to limit lines to 80 characters,
> which led to splitting of these function headers into multiple
> lines and ends the first line with a '('.
> Such splits causes checks reported by the checkpatch.
> 
> Place the function parameters of each function immediately after
> '(' in a single line to align the function headers.
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@...il.com>
> ---
>  .../staging/greybus/audio_manager_module.c    | 40 +++++++++----------
>  1 file changed, 18 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 0a0f0a394c84..81b4ba607a0e 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)
>  	kfree(module);
>  }
>  
> -static ssize_t gb_audio_module_name_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
> +					 struct gb_audio_manager_module_attribute *attr, char *buf)
>  {
>  	return sprintf(buf, "%s", module->desc.name);
>  }
> @@ -80,9 +79,8 @@ static ssize_t gb_audio_module_name_show(
>  static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
>  	__ATTR(name, 0664, gb_audio_module_name_show, NULL);
>  
> -static ssize_t gb_audio_module_vid_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
> +					struct gb_audio_manager_module_attribute *attr, char *buf)
>  {
>  	return sprintf(buf, "%d", module->desc.vid);
>  }
> @@ -90,9 +88,8 @@ static ssize_t gb_audio_module_vid_show(
>  static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
>  	__ATTR(vid, 0664, gb_audio_module_vid_show, NULL);
>  
> -static ssize_t gb_audio_module_pid_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
> +					struct gb_audio_manager_module_attribute *attr, char *buf)
>  {
>  	return sprintf(buf, "%d", module->desc.pid);
>  }
> @@ -100,9 +97,9 @@ static ssize_t gb_audio_module_pid_show(
>  static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
>  	__ATTR(pid, 0664, gb_audio_module_pid_show, NULL);
>  
> -static ssize_t gb_audio_module_intf_id_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *module,
> +					    struct gb_audio_manager_module_attribute *attr,
> +					    char *buf)
>  {
>  	return sprintf(buf, "%d", module->desc.intf_id);
>  }
> @@ -111,9 +108,9 @@ static struct gb_audio_manager_module_attribute
>  					gb_audio_module_intf_id_attribute =
>  	__ATTR(intf_id, 0664, gb_audio_module_intf_id_show, NULL);
>  
> -static ssize_t gb_audio_module_ip_devices_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *module,
> +					       struct gb_audio_manager_module_attribute *attr,
> +					       char *buf)
>  {
>  	return sprintf(buf, "0x%X", module->desc.ip_devices);
>  }
> @@ -122,9 +119,9 @@ static struct gb_audio_manager_module_attribute
>  					gb_audio_module_ip_devices_attribute =
>  	__ATTR(ip_devices, 0664, gb_audio_module_ip_devices_show, NULL);
>  
> -static ssize_t gb_audio_module_op_devices_show(
> -	struct gb_audio_manager_module *module,
> -	struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *module,
> +					       struct gb_audio_manager_module_attribute *attr,
> +					       char *buf)
>  {
>  	return sprintf(buf, "0x%X", module->desc.op_devices);
>  }
> @@ -181,10 +178,9 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
>  	kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
>  }
>  
> -int gb_audio_manager_module_create(
> -	struct gb_audio_manager_module **module,
> -	struct kset *manager_kset,
> -	int id, struct gb_audio_manager_module_descriptor *desc)
> +int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
> +				   struct kset *manager_kset,
> +				   int id, struct gb_audio_manager_module_descriptor *desc)
>  {
>  	int err;
>  	struct gb_audio_manager_module *m;
> -- 
> 2.25.1
> 
>

Hi Mentors,

I came across a same check error in greybus/audio_topology file.
Would it be okay to send a patch similar to this one?

Regards,
Khadija