linux-kernel - Re: [PATCH v2] drivers/gpio : Remove redundant platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf9kwhbZaGjZeN5Jq0Wr_yJtDdj9N48-3o79AMORqmS3w@mail.gmail.com>
Date:   Mon, 20 Mar 2023 12:10:38 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lizhe <sensor1010@....com>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, geert+renesas@...der.be,
        info@...ux.net, rjui@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        sbranden@...adcom.com, shc_work@...l.ru, j-keerthy@...com,
        hoan@...amperecomputing.com, fancer.lancer@...il.com,
        orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        kaloz@...nwrt.org, khalasa@...p.pl, keguang.zhang@...il.com,
        daniel@...ngy.jp, romain.perier@...il.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, grygorii.strashko@...com,
        ssantosh@...nel.org, khilman@...nel.org, mani@...nel.org,
        ludovic.desroches@...rochip.com, andy@...nel.org,
        palmer@...belt.com, paul.walmsley@...ive.com, jonathanh@...dia.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com,
        michal.simek@...inx.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mips@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-pwm@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-unisoc@...ts.infradead.org, linux-riscv@...ts.infradead.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v2] drivers/gpio : Remove redundant platform_set_drvdata().

On Sun, Mar 19, 2023 at 2:01 PM Lizhe <sensor1010@....com> wrote:
>
> platform_set_drvdata() is redundant in these functions.
> the purpose of calling this function is to place data
> in *driver_data. but the data is not retrieved in these
> functions

You need to:
1) split the series on per driver basis (not all of the drivers are
going thru the same subsystem);
2) improve English grammar and style in your commit message;
3) carefully explain in the cover letter your methods of finding the
places you think need to be improved.

Before that it's a waste of time to look at your contributions.

-- 
With Best Regards,
Andy Shevchenko