linux-kernel - [PATCH] staging: most: use inline functions for to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2023 12:33:56 +0200
From:   Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     outreachy@...ts.linux.dev, parthiban.veerasooran@...rochip.com,
        christian.gromm@...rochip.com, u.kleine-koenig@...gutronix.de,
        peda@...ntia.se, srinivas.pandruvada@...ux.intel.com,
        sebastian.reichel@...labora.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, eng.mennamahmoud.mm@...il.com,
        Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH] staging: most: use inline functions for to_hdm

Convert `to_hdm` macro into a static inline function.
it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell
what type it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
---
 drivers/staging/most/i2c/i2c.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c
index df53a4c4f850..4e85e681922f 100644
--- a/drivers/staging/most/i2c/i2c.c
+++ b/drivers/staging/most/i2c/i2c.c
@@ -44,7 +44,10 @@ struct hdm_i2c {
 	char name[64];
 };
 
-#define to_hdm(iface) container_of(iface, struct hdm_i2c, most_iface)
+static inline struct hdm_i2c *to_hdm(struct most_interface *iface)
+{
+	return container_of(iface, struct hdm_i2c, most_iface);
+}
 
 static irqreturn_t most_irq_handler(int, void *);
 static void pending_rx_work(struct work_struct *);
-- 
2.34.1