linux-kernel - Re: [PATCH] usb: typec: tipd: remove unused tps6598x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBhKZ3gVjLnblezP@kuha.fi.intel.com>
Date:   Mon, 20 Mar 2023 13:58:31 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Tom Rix <trix@...hat.com>
Cc:     gregkh@...uxfoundation.org, nathan@...nel.org,
        ndesaulniers@...gle.com, sven@...npeter.dev, agx@...xcpu.org,
        Jonathan.Cameron@...wei.com, jun.nie@...aro.org,
        u.kleine-koenig@...gutronix.de, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32
 functions

On Sun, Mar 19, 2023 at 09:37:32AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tipd/core.c:180:19: error: unused function
>   'tps6598x_write16' [-Werror,-Wunused-function]
> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
>                   ^
> drivers/usb/typec/tipd/core.c:185:19: error: unused function
>   'tps6598x_write32' [-Werror,-Wunused-function]
> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
>                   ^
> These static functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 485b90c13078..af6ecb54b52c 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -177,16 +177,6 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val)
>  	return tps6598x_block_read(tps, reg, val, sizeof(u64));
>  }
>  
> -static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
> -{
> -	return tps6598x_block_write(tps, reg, &val, sizeof(u16));
> -}
> -
> -static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
> -{
> -	return tps6598x_block_write(tps, reg, &val, sizeof(u32));
> -}
> -
>  static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val)
>  {
>  	return tps6598x_block_write(tps, reg, &val, sizeof(u64));

thanks,

-- 
heikki