linux-kernel - Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ab9dd9a-f35c-e8d8-69cc-bd42ed150f94@csgroup.eu>
Date:   Mon, 20 Mar 2023 13:42:32 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Tom Rix <trix@...hat.com>,
        "qiang.zhao@....com" <qiang.zhao@....com>,
        "leoyang.li@....com" <leoyang.li@....com>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
CC:     "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function



Le 20/03/2023 à 13:52, Tom Rix a écrit :
> clang with W=1 reports
> drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
>    'qe_ic_from_irq' [-Werror,-Wunused-function]
> static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
>                              ^
> The use of this function was removed with
> commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions")
> 
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
> v2: Add to commit log when the use was removed.
> 
> ---
>   drivers/soc/fsl/qe/qe_ic.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> index bbae3d39c7be..c0b4f865fba9 100644
> --- a/drivers/soc/fsl/qe/qe_ic.c
> +++ b/drivers/soc/fsl/qe/qe_ic.c
> @@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32  __iomem *base, unsigned int reg,
>   	iowrite32be(value, base + (reg >> 2));
>   }
>   
> -static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
> -{
> -	return irq_get_chip_data(virq);
> -}
> -
>   static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d)
>   {
>   	return irq_data_get_irq_chip_data(d);