linux-kernel - Re: [PATCH v2] platform: olpc: use SPI device ID data to bind device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22d2e345-3640-c8b4-e913-204f1d96dde3@redhat.com>
Date:   Mon, 20 Mar 2023 14:50:20 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform: olpc: use SPI device ID data to bind device

Hi,

On 3/16/23 17:03, Krzysztof Kozlowski wrote:
> The driver defines spi_device_id table for module autoloading, but does
> not use it in id_table which causes W=1 warning:
> 
>   drivers/platform/olpc/olpc-xo175-ec.c:737:35: error: ‘olpc_xo175_ec_id_table’ defined but not used [-Werror=unused-const-variable=]
> 
> Reference the SPI device ID table, so it can be also used for device
> binding.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> 
> ---
> 
> Changes since v1:
> 1. Rework the patch - reference the ID table instead of __maybe_unused.
> ---
>  drivers/platform/olpc/olpc-xo175-ec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/olpc/olpc-xo175-ec.c b/drivers/platform/olpc/olpc-xo175-ec.c
> index 4823bd2819f6..62ccbcb15c74 100644
> --- a/drivers/platform/olpc/olpc-xo175-ec.c
> +++ b/drivers/platform/olpc/olpc-xo175-ec.c
> @@ -746,6 +746,7 @@ static struct spi_driver olpc_xo175_ec_spi_driver = {
>  		.of_match_table = olpc_xo175_ec_of_match,
>  		.pm = &olpc_xo175_ec_pm_ops,
>  	},
> +	.id_table	= olpc_xo175_ec_id_table,
>  	.probe		= olpc_xo175_ec_probe,
>  	.remove		= olpc_xo175_ec_remove,
>  };