linux-kernel - Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2023 07:00:58 -0700
From:   Chris Healy <cphealy@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux@...linux.org.uk, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-imx@....com, arnd@...db.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        andrew@...n.ch, Chris Healy <healych@...zon.com>
Subject: Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

On Sun, Mar 19, 2023 at 8:07 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Chris,
>
> On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <cphealy@...il.com> wrote:
> >
> > From: Chris Healy <healych@...zon.com>
> >
> > The imx53 base imx53qsb uses an SMSC Ethernet PHY.  Enable it's driver.
> >
> > Signed-off-by: Chris Healy <healych@...zon.com>
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> > index 6dc6fed12af8..a12d45e99782 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
> >  # CONFIG_NET_VENDOR_STMICRO is not set
> >  CONFIG_MICREL_PHY=y
> >  CONFIG_AT803X_PHY=y
> > +CONFIG_SMSC_PHY=y
>
> Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
> selected by default
> because USB_NET_SMSC95XX is already enabled.
>
> It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
> done in this patch.

I see what you are saying.  I agree this patch is no longer necessary.  Tnx.