linux-kernel - RE: [PATCH v2 1/1] rcu/rcuscale: Stop kfree_scale_thread thread(s) after unloading rcuscale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB61710BAF452AE6E687D8F3CE89819@IA1PR11MB6171.namprd11.prod.outlook.com>
Date:   Tue, 21 Mar 2023 01:21:21 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     "paulmck@...nel.org" <paulmck@...nel.org>
CC:     "dave@...olabs.net" <dave@...olabs.net>,
        "frederic@...nel.org" <frederic@...nel.org>,
        "jiangshanlai@...il.com" <jiangshanlai@...il.com>,
        "joel@...lfernandes.org" <joel@...lfernandes.org>,
        "josh@...htriplett.org" <josh@...htriplett.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "quic_neeraju@...cinc.com" <quic_neeraju@...cinc.com>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>
Subject: RE: [PATCH v2 1/1] rcu/rcuscale: Stop kfree_scale_thread thread(s)
 after unloading rcuscale

> From: Paul E. McKenney <paulmck@...nel.org>
> Sent: Tuesday, March 21, 2023 4:41 AM
> [...]
> >
> > Fixes: e6e78b004fa7 ("rcuperf: Add kfree_rcu() performance Tests")
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> 
> Much better!
> 
> Except that someone glancing at this patch would be hard pressed to see
> what changed.

Indeed.

> So could you please split this into two patches, the first of which does
> nothing but move code, and the second of which makes the actual change?

OK. 
Will split this patch into two patches in the v3.

> The commit log for the first patch needs to clearly state that the it is code-
> motion-only, with no change in behavior.

OK.
Thanks so much for your suggestions ;-) 

> 
> 							Thanx, Paul