linux-kernel - Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e44aa00-9896-8869-1707-fe8e5815e9c7@amd.com>
Date:   Tue, 21 Mar 2023 16:15:55 +0100
From:   Michal Simek <michal.simek@....com>
To:     "Katakam, Harini" <harini.katakam@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "romain.perier@...il.com" <romain.perier@...il.com>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "yukuai3@...wei.com" <yukuai3@...wei.com>
Cc:     "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "harinikatakamlinux@...il.com" <harinikatakamlinux@...il.com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks



On 3/21/23 16:04, Katakam, Harini wrote:
> Hi Michal,
> 
>> -----Original Message-----
>> From: Simek, Michal <michal.simek@....com>
>> Sent: Tuesday, March 21, 2023 8:15 PM
>> To: Katakam, Harini <harini.katakam@....com>; vkoul@...nel.org;
>> romain.perier@...il.com; allen.lkml@...il.com; yukuai3@...wei.com
>> Cc: dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
>> kernel@...r.kernel.org; harinikatakamlinux@...il.com; Pandey, Radhey
>> Shyam <radhey.shyam.pandey@....com>
>> Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent
>> masks
>>
>>
>>
>> On 3/16/23 10:33, Harini Katakam wrote:
>>> Align ZDMA DMA as well as coherent memory masks to 44 bit. This is
>>> required when using >32 bit memory regions.
>>
>> It doesn't look like description aligned with the change below.
>> You are using 44 bit already and the patch itself just checking return value
>> from that function.
> 
> Current code sets dma_set_mask; I changed it to dma_set_mask_and_coherent

Ah ok. Then

Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal