linux-kernel - Re: [PATCH] staging: greybus: fix line ending with '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBnZD5alylOgjhYd@khadija-virtual-machine>
Date:   Tue, 21 Mar 2023 21:19:27 +0500
From:   Khadija Kamran <kamrankhadijadj@...il.com>
To:     outreachy@...ts.linux.dev
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: fix line ending with '('

On Mon, Mar 20, 2023 at 05:10:40PM +0500, Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the first parameter right after the '(' in the function call line.
> Align the rest of the parameters to the opening parenthesis.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  drivers/staging/greybus/audio_topology.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 62d7674852be..08e6a807c132 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {
>  	struct gb_audio_ctl_elem_info *info;
>  };
> 
> -static struct gbaudio_module_info *find_gb_module(
> -					struct gbaudio_codec_info *codec,
> -					char const *name)
> +static struct gbaudio_module_info *find_gb_module(struct gbaudio_codec_info *codec,
> +						  char const *name)
>  {
>  	int dev_id;
>  	char begin[NAME_SIZE];
> --
> 2.34.1
>

Hey Outreachy Mentors,

Kindly take a look at this patch and let me know if I should wait for
the response on this patch or submit another patch.

Thank you for your time.
Regards,
Khadija