linux-kernel - Re: [PATCH v2] net: dsa: tag_brcm: legacy: fix daisy-chained switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230320185806.5dd71c90@kernel.org>
Date:   Mon, 20 Mar 2023 18:58:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     f.fainelli@...il.com
Cc:     Álvaro Fernández Rojas <noltari@...il.com>,
        andrew@...n.ch, jonas.gorski@...il.com, olteanv@...il.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH v2] net: dsa: tag_brcm: legacy: fix daisy-chained
 switches

On Sun, 19 Mar 2023 10:55:40 +0100 Álvaro Fernández Rojas wrote:
> When BCM63xx internal switches are connected to switches with a 4-byte
> Broadcom tag, it does not identify the packet as VLAN tagged, so it adds one
> based on its PVID (which is likely 0).
> Right now, the packet is received by the BCM63xx internal switch and the 6-byte
> tag is properly processed. The next step would to decode the corresponding
> 4-byte tag. However, the internal switch adds an invalid VLAN tag after the
> 6-byte tag and the 4-byte tag handling fails.
> In order to fix this we need to remove the invalid VLAN tag after the 6-byte
> tag before passing it to the 4-byte tag decoding.

Is it good to go in, Florian?