linux-kernel - Re: [GIT PULL] keys: Miscellaneous fixes/changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh1b0r+5SnwWedx=J4aZhRif1HLN_moxEG9Jzy23S6QUA@mail.gmail.com>
Date:   Tue, 21 Mar 2023 11:48:17 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Howells <dhowells@...hat.com>, Jens Axboe <axboe@...nel.dk>
Cc:     Jarkko Sakkinen <jarkko@...nel.org>,
        Bharath SM <bharathsm@...rosoft.com>,
        Shyam Prasad N <nspmangalore@...il.com>,
        Steve French <smfrench@...il.com>,
        Robbie Harwood <rharwood@...hat.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        keyrings@...r.kernel.org, linux-cifs@...r.kernel.org,
        linux-crypto@...r.kernel.org, kexec@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] keys: Miscellaneous fixes/changes

On Tue, Mar 21, 2023 at 9:43 AM David Howells <dhowells@...hat.com> wrote:
>
>  (1) Fix request_key() so that it doesn't cache a looked up key on the
>      current thread if that thread is a kernel thread.  The cache is
>      cleared during notify_resume - but that doesn't happen in kernel
>      threads.  This is causing cifs DNS keys to be un-invalidateable.

I've pulled this, but I'd like people to look a bit more at this.

The issue with TIF_NOTIFY_RESUME is that it is only done on return to
user space.

And these days, PF_KTHREAD isn't the only case that never returns to
user space. PF_IO_WORKER has the exact same behaviour.

Now, to counteract this, as of this merge window (and marked for
stable) IO threads do a fake "return to user mode" handling in
io_run_task_work(), and so I think we're all good, but I'd like people
to at least think about this.

              Linus