linux-kernel - Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41e59e5d-9bf7-2834-4fd1-09ec4c48fa24@huawei.com>
Date:   Tue, 21 Mar 2023 10:21:40 +0800
From:   liulongfang <liulongfang@...wei.com>
To:     Jason Gunthorpe <jgg@...dia.com>,
        Alex Williamson <alex.williamson@...hat.com>
CC:     <shameerali.kolothum.thodi@...wei.com>,
        <jonathan.cameron@...wei.com>, <cohuck@...hat.com>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...neuler.org>
Subject: Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration
 driver

On 2023/3/21 5:42, Jason Gunthorpe wrote:
> On Mon, Mar 20, 2023 at 03:33:36PM -0600, Alex Williamson wrote:
> 
>> This would allow that mlx5 and future drivers automatically get this
>> with no driver code, and in fact all devices would get debugfs dev_name
>> directories for better test coverage.  hisi_acc would only need to add
>> driver specific entries after registering the device and free any
>> related data after unregistering the device.  In this way, none of the
>> entry points here would need to be exported for drivers, which is
>> perhaps the direction Jason was thinking with his prior comments.
> 
> Yes, my point was more not to add more ops specifically to wrapper
> debugfs stuff. If drivers want a special debugfs file then there is
> lots of infrastructure to just create that off a common point
> 

OK! I understand what you and Alex are asking for.
I will re-debug a version based on your request.

Thanks.
Longfang.
> Jason
> .
>