linux-kernel - Re: [PATCH 2/2] Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <734f5548-a572-ff52-c7c1-312c4ad70058@tuxedocomputers.com>
Date:   Tue, 21 Mar 2023 20:18:10 +0100
From:   Werner Sembach <wse@...edocomputers.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>, tiwai@...e.de,
        samuel@...oj.net, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: i8042 - add TUXEDO devices to i8042 quirk
 tables for partial fix


Am 21.03.23 um 19:53 schrieb Dmitry Torokhov:
> Hi Werner,
>
> On Tue, Mar 21, 2023 at 05:10:19PM +0100, Werner Sembach wrote:
>> Am 11.07.22 um 14:55 schrieb Hans de Goede:
>>> Hi,
>>>
>>> On 7/11/22 14:45, Werner Sembach wrote:
>>>> Hi,
>>>>
>>>> On 7/8/22 21:39, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> On 7/8/22 18:10, Werner Sembach wrote:
>>>>>> A lot of modern Clevo barebones have touchpad and/or keyboard issues after
>>>>>> suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
>>>>>> have an external PS/2 port so this can safely be set for all of them.
>>>>>>
>>>>>> I'm not entirely sure if every device listed really needs all four quirks,
>>>>>> but after testing and production use. No negative effects could be
>>>>>> observed when setting all four.
>>>>>>
>>>>>> Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS on the Clevo N150CU
>>>>>> and the Clevo NHxxRZQ makes the keyboard very laggy for ~5 seconds after
>>>>>> boot and sometimes also after resume. However both are required for the
>>>>>> keyboard to not fail completely sometimes after boot or resume.
>>>>> Hmm, the very laggy bit does not sound good. Have you looked into other
>>>>> solutions, e.g. what happens if you use just nomux without any of the
>>>>> other 3 options ?
>>>> I tried a lot of combinations, but it was some time ago.
>>>>
>>>> iirc: at least nomux and reset are required and both individually cause the lagging.
>>>>
>>>> So the issue is not fixed by just using a different set of quirks.
>>> Hmm, ok. So given that this seems to be the best we can do
>>> the patch looks good to me:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>>>
>>> Regards,
>>>
>>> Hans
>> Afaik this patch never got merged. Sadly I still have no better solution, so
>> I wanted to bring the patch up for discussion again as it still makes the
>> situation better in my opinion.
> Could you rebase on top of the latest kernel?
>
> Thanks.
>
ofc, sent as v3