linux-kernel - Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 21:13:49 +0100
From:   Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
To:     linux-kbuild@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name

On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
> Hi all,
> 
> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the
> script returning:
> 
> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config
> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found
> 
> Problem is probably best explained by this diff:
> 
> ---
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>                  NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>                  BUILTIN_FLAG=false
>                  if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> -                       ${WARNOVVERIDE} Previous  value: $PREV_VAL
> +                       ${WARNOVERRIDE} Previous  value: $PREV_VAL
>                          ${WARNOVERRIDE} New value:       $NEW_VAL
>                          ${WARNOVERRIDE} -y passed, will not demote y to m
>                          ${WARNOVERRIDE}
> 
> Hope this helps.

P.S.

Later I thought of searching the committer of the patch that introduced the change,
so I Cc:ed Mark.

Best regards,
Mirsad

-- 
Mirsad Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355