linux-kernel - Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f657b9c5-961d-4b2f-a7e2-47a2a66de9dd@lunn.ch>
Date:   Tue, 21 Mar 2023 21:17:28 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Sergey Shtylyov <s.shtylyov@....ru>,
        Steve Glendinning <steve.glendinning@...well.net>,
        Wells Lu <wellslutw@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev

On Tue, Mar 21, 2023 at 02:17:45PM +0100, Wolfram Sang wrote:
> phy_disconnect() calls phy_detach() which already clears 'phydev' if it
> is attached to a struct net_device.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew