linux-kernel - Re: [PATCH] s390: reintroduce expoline dependence to scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <your-ad-here.call-01679433546-ext-8459@work.hours>
Date:   Tue, 21 Mar 2023 22:19:06 +0100
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Joe Lawrence <joe.lawrence@...hat.com>, stable@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: reintroduce expoline dependence to scripts

On Thu, Mar 16, 2023 at 12:28:09PM +0100, Jiri Slaby (SUSE) wrote:
> Expolines depend on scripts/basic/fixdep. And build of expolines can now
> race with the fixdep build:
> 
>  make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
>  /bin/sh: line 1: scripts/basic/fixdep: Permission denied
>  make[1]: *** [../scripts/Makefile.build:385: arch/s390/lib/expoline/expoline.o] Error 126
>  make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2
> 
> The dependence was removed in the below Fixes: commit. So reintroduce
> the dependence on scripts.
> 
> Fixes: a0b0987a7811 ("s390/nospec: remove unneeded header includes")
> Cc: Joe Lawrence <joe.lawrence@...hat.com>
> Cc: stable@...r.kernel.org
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> ---
>  arch/s390/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index b3235ab0ace8..ed646c583e4f 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -162,7 +162,7 @@ vdso_prepare: prepare0
>  
>  ifdef CONFIG_EXPOLINE_EXTERN
>  modules_prepare: expoline_prepare
> -expoline_prepare:
> +expoline_prepare: scripts
>  	$(Q)$(MAKE) $(build)=arch/s390/lib/expoline arch/s390/lib/expoline/expoline.o
>  endif
>  endif
> -- 

Applied, thank you.