linux-kernel - [PATCH v5 1/3] crypto: ccp: Bump up doorbell debug messages to error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230321212822.5714-2-mario.limonciello@amd.com>
Date:   Tue, 21 Mar 2023 16:28:19 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Mark Hasemeyer <markhas@...omium.org>,
        Grzegorz Bernacki <gjb@...ihalf.com>,
        Mario Limonciello <mario.limonciello@....com>,
        "Tom Lendacky" <thomas.lendacky@....com>,
        John Allen <john.allen@....com>
CC:     <jsd@...ihalf.com>, Held Felix <Felix.Held@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH v5 1/3] crypto: ccp: Bump up doorbell debug messages to error

This is helpful not just for debugging problems, but also for investigating
captured logs later on.

Suggested-by: Grzegorz Bernacki <gjb@...ihalf.com>
Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
 drivers/crypto/ccp/platform-access.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
index b51fb1196932..b9f94e1aeb78 100644
--- a/drivers/crypto/ccp/platform-access.c
+++ b/drivers/crypto/ccp/platform-access.c
@@ -157,19 +157,19 @@ int psp_ring_platform_doorbell(int msg)
 	mutex_lock(&pa_dev->doorbell_mutex);
 
 	if (check_doorbell(button)) {
-		dev_dbg(psp->dev, "doorbell is not ready\n");
+		dev_err(psp->dev, "doorbell is not ready\n");
 		ret = -EBUSY;
 		goto unlock;
 	}
 
 	if (check_recovery(cmd)) {
-		dev_dbg(psp->dev, "doorbell command in recovery\n");
+		dev_err(psp->dev, "doorbell command in recovery\n");
 		ret = -EBUSY;
 		goto unlock;
 	}
 
 	if (wait_cmd(cmd)) {
-		dev_dbg(psp->dev, "doorbell command not done processing\n");
+		dev_err(psp->dev, "doorbell command not done processing\n");
 		ret = -EBUSY;
 		goto unlock;
 	}
@@ -184,6 +184,7 @@ int psp_ring_platform_doorbell(int msg)
 
 	val = FIELD_GET(PSP_CMDRESP_STS, ioread32(cmd));
 	if (val) {
+		dev_err(psp->dev, "doorbell response invalid: 0x%x\n", val);
 		ret = -EIO;
 		goto unlock;
 	}
-- 
2.34.1