linux-kernel - Re: [PATCH v2] staging: greybus: use inline function for macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48674d8f-9753-780c-f37c-f83ea2855ae6@ieee.org>
Date:   Tue, 21 Mar 2023 17:42:09 -0500
From:   Alex Elder <elder@...e.org>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>,
        gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
        johan@...nel.org, elder@...nel.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2] staging: greybus: use inline function for macros

On 3/21/23 4:29 PM, Julia Lawall wrote:
> There do seem to be more than 100 definitions like:
> 
> #define to_dove_clk(hw) container_of(hw, struct dove_clk, hw)
> 
> where we have to hope that at all of the usage sites the argument is
> called hw.  Probably anything else would cause a compiler error, but still
> it looks strange.
> 
> julia

Yeah, that's poorly done and unfortunate.  The argument to
the parameter should be named something different.  I didn't
understand what you meant before but yes, this isn't good.
These should be fixed first.

					-Alex